- The code has a lot of similar ifs at many places
- To fix a bug you have to apply the same fix at many places
- Your code has a lot ifs doing enum/type/string comparison to decide the function to be called for a particular object
- It is difficult to find out which function is called when
- Many classes in the code has more than 20 functions
- The number of classes with similar names is endless in your project
- Get/Set functions are virtual
- You can’t understand the purpose of the class by looking at its header file
- This is derived from that and that is derived from that and that is derived from that, so this and that have a ‘is a relationship’…didn’t get it…let us start again…
- Derived class doesn’t override even one virtual function defined in the base class
- Almost every new feature needs changes in at least 10% of the files in the project
- You can copy and paste the code Reviewer of the code always says, I am looking at this code for the first time…
- The number of Abstract classes…are you not able to find any?
Sunday, July 18, 2010
Assignment Day 1:Sniffing
Subscribe to:
Post Comments (Atom)
1: If the code is having a lot of global variables.
ReplyDeleteHaving too many public and protected data members.
ReplyDeleteclass UIBase_X : public wxPanel
ReplyDeleteclass JPUIBase : public UIBase_X
class JPUIBaseControl: public JPUIBase
class JPUIComboBox : public JPUIBaseControl
class JPUIPageSize : public JPUIComboBox
class JPUIDocumentSize : public JPUIPageSize
Above shows the indeterminate level of growing hierarchies in JP
ReplyDeleteHaving uninitialized variables and pointers.
ReplyDeleteClass exposes only set and get functions
ReplyDelete